Skip to content

Conversation

@jverzani
Copy link
Contributor

@jverzani jverzani commented Mar 4, 2025

  • Adds some generic predicates: isreal, isinteger
  • useis_a_Symbol for is_symbol
  • add is_symbol check in
  • adds internal functions to expose several is_a_XXX functions (e.g. is_a_Number, is_a_Integer, ...)
  • exposes basic_coeff as unexported coeff function

This started out by trying to find a zero allocation check for whether an object is a symbol and for has_symbol. But along the way, realized some other useful pieces of cwrapper might be exposed.

@jverzani
Copy link
Contributor Author

@isuruf Can I go ahead and merge this? It will be helpful to make some other calls, like diff, more performant.

@isuruf
Copy link
Member

isuruf commented Mar 17, 2025

Sure!

@jverzani jverzani merged commit 22de316 into symengine:master Mar 17, 2025
9 checks passed
@jverzani jverzani deleted the predicates branch March 17, 2025 14:26
@jverzani
Copy link
Contributor Author

Thanks, with this I can speed up both diff and N quite a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants